On Wed, Dec 04, 2019 at 01:52:13PM +0100, Jan Kara wrote: > On Wed 04-12-19 20:46:12, zhangyi (F) wrote: > > JBD2_REC_ERR flag used to indicate the errno has been updated when jbd2 > > aborted, and then __ext4_abort() and ext4_handle_error() can invoke > > panic if ERRORS_PANIC is specified. But if the journal has been aborted > > with zero errno, jbd2_journal_abort() didn't set this flag so we can > > no longer panic. Fix this by always record the proper errno in the > > journal superblock. > > > > Fixes: 4327ba52afd03 ("ext4, jbd2: ensure entering into panic after recording an error in superblock") > > Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx> > > Looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Applied, thanks. - Ted