On Fri, Jan 10, 2020 at 11:52:17AM +0300, Anatoly Pugachev wrote: > > libext2fs: extends commit c9a8c53b, with the same fix for ext2fs_flush2() and > ext2fs_image_super_write() on a Big Endian systems. > > As follow-up to previous discussion 'dumpe2fs / mke2fs sigserv on sparc64' > > Used find for files which refer to: > > e2fsprogs.git$ find . -name \*.c | xargs grep -cl 'gdp = ext2fs_group_desc' > ./lib/ext2fs/closefs.c > ./lib/ext2fs/openfs.c > ./lib/ext2fs/imager.c > > And applied the same check for a null pointer. > > Tested on a debian linux with sparc64 LDOM and ppc64 LPAR. > > Fixes sigserv with test suite in "i_bitmaps" test. As far as I know, the i_bitmaps test is passing on on sparc64 and ppc64. Search for i_bitmaps in: https://buildd.debian.org/status/fetch.php?pkg=e2fsprogs&arch=sparc64&ver=1.45.5-2&stamp=1578527938&raw=0 and https://buildd.debian.org/status/fetch.php?pkg=e2fsprogs&arch=ppc64&ver=1.45.5-2&stamp=1578526270&raw=0 The bug in c9a8c53b was caused by SPARSE_SUPER being passed to ext2fs_open(). But that doesn't happen in misc/e2image. I can see optimizing ext2fs_flush() to skip byte-swapping the group descriptors if the SUPER_ONLY flag is enabled. And I can see ext2fs_image_super_write() checking to see if the SUPER_ONLY flag is set, and returning an error in that case. But I don't think any of the current e2fsprogs are crashing at the moment. Am I missing something? Regards, - Ted
