Re: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Lutomirski <luto@xxxxxxxxxx>
Subject: Re: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1
From: "Theodore Y. Ts'o" <tytso@xxxxxxx>
Date: Tue, 7 Jan 2020 15:42:50 -0500
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linux API <linux-api@xxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Jason A. Donenfeld" <Jason@xxxxxxxxx>, "Ahmed S. Darwish" <darwish.07@xxxxxxxxx>, Lennart Poettering <mzxreary@xxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, "Alexander E. Patrakov" <patrakov@xxxxxxxxx>, Michael Kerrisk <mtk.manpages@xxxxxxxxx>, Willy Tarreau <w@xxxxxx>, Matthew Garrett <mjg59@xxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, linux-man <linux-man@xxxxxxxxxxxxxxx>, Stephan Mueller <smueller@xxxxxxxxxx>
In-reply-to: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org>
References: <cover.1577088521.git.luto@kernel.org> <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org>

On Mon, Dec 23, 2019 at 12:20:44AM -0800, Andy Lutomirski wrote:
> crng_init_wait is only used to wayt for crng_init to be set to 2, so
> there's no point to waking it when crng_init is set to 1.  Remove the
> unnecessary wake_up_interruptible() call.
> 
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>

Applied with a spelling fix ("wayt->wait").

					- Ted

References:
- [PATCH v3 0/8] Rework random blocking
  - From: Andy Lutomirski
- [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1
  - From: Andy Lutomirski

Prev by Date: [PATCH] fs: fix ext4 unused-variable warning
Next by Date: Re: [PATCH v3 2/8] random: Add a urandom_read_nowait() for random APIs that don't warn
Previous by thread: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1
Next by thread: [PATCH v3 2/8] random: Add a urandom_read_nowait() for random APIs that don't warn
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]