On 12/31/19 11:34 PM, Eric Biggers wrote:
This series makes a few cleanups to things I noticed while reading some
of the code in extents.c.
No actual changes in behavior.
Eric Biggers (8):
ext4: remove ext4_{ind,ext}_calc_metadata_amount()
ext4: clean up len and offset checks in ext4_fallocate()
ext4: remove redundant S_ISREG() checks from ext4_fallocate()
ext4: make some functions static in extents.c
ext4: fix documentation for ext4_ext_try_to_merge()
ext4: remove obsolete comment from ext4_can_extents_be_merged()
ext4: fix some nonstandard indentation in extents.c
ext4: add missing braces in ext4_ext_drop_refs()
> fs/ext4/ext4.h | 11 ----
fs/ext4/ext4_extents.h | 5 --
fs/ext4/extents.c | 143 +++++++++++++----------------------------
fs/ext4/indirect.c | 26 --------
fs/ext4/inode.c | 3 -
fs/ext4/super.c | 2 -
6 files changed, 45 insertions(+), 145 deletions(-)
Nice cleanup.
While reviewing your patch series also found an unused macro
"MPAGE_DA_EXTENT_TAIL" in inode.c file. Submitted a patch on top of
this series itself. Maybe it can be included as part of your extent
cleanup series itself.
Patch:- "ext4: remove unused macro MPAGE_DA_EXTENT_TAIL"
In your series I think that last 4 commits could be squashed into 1
commit itself, since those 4 patches are related to comments or
minor indentations in extents.c file. But no major objection on that.
Either ways, you may add.
Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
-ritesh
