On Wed, Nov 06, 2019 at 11:14:42AM +0100, Lukas Czerner wrote:
> + fsparam_string_empty
> + ("usrjquota", Opt_usrjquota),
> + fsparam_string_empty
> + ("grpjquota", Opt_grpjquota),
Umm... That makes ...,usrjquota,... equivalent to ...,usrjquota=,...
unless I'm misreading the series. Different from mainline, right?
> + fsparam_bool ("barrier", Opt_barrier),
> + fsparam_flag ("nobarrier", Opt_nobarrier),
That's even more interesting. Current mainline:
barrier OK, sets EXT4_MOUNT_BARRIER
barrier=0 OK, sets EXT4_MOUNT_BARRIER
barrier=42 OK, sets EXT4_MOUNT_BARRIER
barrier=yes error
barrier=no error
nobarrier OK, clears EXT4_MOUNT_BARRIER
Unless I'm misreading your series, you get
barrier error
barrier=0 OK, sets EXT4_MOUNT_BARRIER
barrier=42 error
barrier=yes OK, sets EXT4_MOUNT_BARRIER
barrier=no OK, sets EXT4_MOUNT_BARRIER
nobarrier OK, clears EXT4_MOUNT_BARRIER
Granted, mainline behaviour is... unintuitive, to put it mildly,
but the replacement is just as strange _and_ incompatible with the
existing one.
Am I missing something subtle there?
