Re: [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alan Maguire <alan.maguire@xxxxxxxxxx>
Subject: Re: [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h
From: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Date: Tue, 19 Nov 2019 10:48:01 -0800
Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, KUnit Development <kunit-dev@xxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Iurii Zaikin <yzaikin@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, catalin.marinas@xxxxxxx, joe.lawrence@xxxxxxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, schowdary@xxxxxxxxxx, urezki@xxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, Jonathan Corbet <corbet@xxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, adilger.kernel@xxxxxxxxx, Luis Chamberlain <mcgrof@xxxxxxxxxx>, changbin.du@xxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>
In-reply-to: <1573812972-10529-3-git-send-email-alan.maguire@oracle.com>
References: <1573812972-10529-1-git-send-email-alan.maguire@oracle.com> <1573812972-10529-3-git-send-email-alan.maguire@oracle.com>

On Fri, Nov 15, 2019 at 2:17 AM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote:
>
> Define function as static inline in try-catch-impl.h to allow it to
> be used in kunit itself and tests.  Also remove unused
> kunit_generic_try_catch
>
> Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Aside from Stephen's comment, this looks good to me.

References:
- [PATCH v4 linux-kselftest-test 0/6] kunit: support building core/tests as modules
  - From: Alan Maguire
- [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h
  - From: Alan Maguire

Prev by Date: Re: [PATCH v4 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit
Next by Date: Re: [PATCH v4 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Previous by thread: Re: [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h
Next by thread: [PATCH v4 linux-kselftest-test 4/6] kunit: remove timeout dependence on sysctl_hung_task_timeout_seconds
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]