On Sat, Nov 16, 2019 at 5:33 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Alan Maguire (2019-11-15 02:16:07) > > string-stream interfaces are not intended for external use; > > move them from include/kunit to lib/kunit accordingly. > > > > Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx> > > Signed-off-by: Knut Omang <knut.omang@xxxxxxxxxx> > > The sign off chain is incorrect here. Is Knut tag supposed to be > Co-developed-by? I am not sure what the relationship between Alan and Knut on this patch. Nevertheless, Signed-off-by is required either way, but it seems that Co-developed-by is optional depending on how Alan and Knut would like to share credit for this patch, at least that is based on my reading of the submitting patches guide: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > > diff --git a/include/kunit/assert.h b/include/kunit/assert.h > > index db6a0fc..ad889b5 100644 > > --- a/include/kunit/assert.h > > +++ b/include/kunit/assert.h > > @@ -9,10 +9,11 @@ > > #ifndef _KUNIT_ASSERT_H > > #define _KUNIT_ASSERT_H > > > > -#include <kunit/string-stream.h> > > #include <linux/err.h> > > +#include <linux/kernel.h> > > Why is this included now? Nice catch! I think I would have missed that. > > > > struct kunit; > > +struct string_stream; > > > > /** > > * enum kunit_assert_type - Type of expectation/assertion. Cheers!
