On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote: > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > I'm working on an xfstest for this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > are any issues from that, I'll hear about it. > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > a patch set? > > > > That's generally not done since the test goes to a different repo > > (xfstests.git) which has a different review process from the kernel > > change. > > OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That > is why I'm looking into setting up test environment so that I can review > these patches with a sane judgement. And also since I've just barely started to help David on co-maintaining keyring it is better to put extra emphasis on testing even for the most trivial patches. That is fastest way to learn different interactions. /Jarkko
