Sorry, and got it. I asked my employer but it can take a while to get a response, so feel free to make the change yourself if you'd like. I'd be curious if you think it is a good change. Best, Jesse On Thu, Nov 14, 2019 at 7:27 PM Theodore Y. Ts'o <tytso@xxxxxxx> wrote: > > On Thu, Nov 14, 2019 at 05:05:06PM +0200, Jesse Grodman wrote: > > Hi, > > > > I encountered the scenario that a full fsck check was being run > > unnecessarily when the major / minor number of my external journal was > > being fixed by fsck. This PR changes that so that this change does > > trigger the full fsck run: github.com/tytso/e2fsprogs/pull/26 > > Hi Jessie, > > It's preferable that patches e2fsprogs be sent to the linux-ext4 list, > so they can get reviewed by the full ext4 community. That being said, > I will accept minor patches sent via a pull request if they full meet > the requirements for kernel patches: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Note in particular the requirements for the Developer's Certification > of Origin (aka the Signed-off-by tag). That has specific legal > meanings (for example, you are certifying that your employer allows > you to contribute to open source projects, or at least, *this* open > source project), so please take a close look at that. > > Cheers, > > - Ted