On Tue, Nov 05, 2019 at 03:53:03PM -0500, Theodore Y. Ts'o wrote: > On Wed, Nov 06, 2019 at 07:32:00AM +1100, Matthew Bobrowski wrote: > > > Otherwise you would write out and invalidate too much AFAICT - the 'offset' > > > is position just before we fall back to buffered IO. Otherwise this hunk > > > looks good to me. > > > > Er, yes. That's right, it should rather be 'err' instead or else we > > would write/invalidate too much. I actually had this originally, but I > > must've muddled it up while rewriting this patch on my other computer. > > > > Thanks for picking that up! > > I can fix that up in my tree, unless there are any other changes that > we need to make. If you could, that would be super awesome as I don't really see anything else changing in this series. I'll probably send through some minor optimisations/refactoring cleanups after this series lands, but that can come at a later point. /M
