On Mon 04-11-19 07:36:50, Theodore Y. Ts'o wrote: > On Wed, Oct 23, 2019 at 06:17:24PM +0200, Jan Kara wrote: > > > What is j_state_lock protecting at this point? There's only a 32-bit > > > read of j_commit_request at this point. > > > > We could almost drop the lock. To be fully correct, we'd then need to use > > READ_ONCE here and WRITE_ONCE in places changing j_commit_request (reasons > > are well summarized in recent LWN series on how compiler can screw your > > unlocked reads and writes). So probably a fair cleanup but something I've > > decided to leave for later. > > Fair enough; maybe leave a quick TODO comment so we remember that this > is an outstanding clean up? Good idea. Added. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
