On Wed, Oct 23, 2019 at 12:09:24PM +0530, Ritesh Harjani wrote:
> On 10/22/19 7:25 AM, Matthew Bobrowski wrote:
> > On Mon, Oct 21, 2019 at 03:37:15PM +0200, Jan Kara wrote:
> > > On Mon 21-10-19 20:18:09, Matthew Bobrowski wrote:
> > > One nit below.
> > > > + ext4_es_find_extent_range(inode, &ext4_es_is_delayed,
> > > > + map->m_lblk, end, &es);
> > > > +
> > > > + if (!es.es_len || es.es_lblk > end)
> > > > + return false;
> > > > +
> > > > + if (es.es_lblk > map->m_lblk) {
> > > > + map->m_len = es.es_lblk - map->m_lblk;
> > > > + return false;
> > > > + }
> > > > +
> > > > + if (es.es_lblk <= map->m_lblk)
> > > > + offset = map->m_lblk - es.es_lblk;
> > > > + map->m_lblk = es.es_lblk + offset;
>
> And so, this above line will also be redundant.
And, you're absolutely right. Nice catch. Who knew basic math could go such a
long way? :P
Thanks Ritesh!
--<M>--
