In the case of failure, the num is still initialized value 0 so we should not set it to *count because it will bring unexpected side effect to the caller. Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxxxx> --- fs/ext2/balloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 18e75adcd2f6..cc516c7b7974 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -736,7 +736,6 @@ ext2_try_to_allocate(struct super_block *sb, int group, *count = num; return grp_goal - num; fail_access: - *count = num; return -1; } -- 2.20.1
