---- 在 星期一, 2019-10-21 17:18:00 Jan Kara <jack@xxxxxxx> 撰写 ---- > On Mon 21-10-19 07:23:26, Chengguang Xu wrote: > > Set block num to original *count in a case > > of retrying allocation in case num < *count > > > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxxxx> > > --- > > Hi Jan, > > > > This patch is only compile-tested, I'm not sure if this > > kind of unexpected condition which causes reallocation > > will actually happen but baesd on the code the fix seems > > correct and better. > > Yeah, you are right that we should reset 'num' back to *count. Although the > practial effect of this is minimal - we take this code path only when the > filesystem is corrupted. But still... Patch applied. Thanks! Thanks for your review. I found another relevant bug in ext2_try_to_allocate() today, I'll fix it up and also plan to do some code cleanups for the allocation logic. Do you prefer two separate patches for bugfix and cleanup or just put all in a patch series? Thanks, Chengguang
