On Mon, Oct 21, 2019 at 03:41:31PM +0200, Jan Kara wrote: > On Mon 21-10-19 20:18:37, Matthew Bobrowski wrote: > > This patch introduces a new direct I/O read path which makes use of > > the iomap infrastructure. > > > > The new function ext4_do_read_iter() is responsible for calling into > > the iomap infrastructure via iomap_dio_rw(). If the read operation > > performed on the inode is not supported, which is checked via > > ext4_dio_supported(), then we simply fallback and complete the I/O > > using buffered I/O. > > > > Existing direct I/O read code path has been removed, as it is no > > longer required. > > > > Signed-off-by: Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx> > > Looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > BTW, I think I gave you my Reviewed-by tag for this patch also last time > and this patch didn't change since then. You can just include the tag in > your posting in that case. The lock pattern was dropped here, so I thought I'd just have you review it again to be sure that you didn't object. But anyway, thank you! --<M>--
