On Tue, Oct 15, 2019 at 7:14 PM Theodore Y. Ts'o <tytso@xxxxxxx> wrote:
>
> On Tue, Oct 01, 2019 at 12:40:50AM -0700, Harshad Shirwadkar wrote:
> > @@ -1858,8 +1863,9 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
> > set_opt2(sb, EXPLICIT_DELALLOC);
> > } else if (m->mount_opt & EXT4_MOUNT_JOURNAL_CHECKSUM) {
> > set_opt2(sb, EXPLICIT_JOURNAL_CHECKSUM);
> > - } else
> > + } else if (m->mount_opt) {
> > return -1;
> > + }
> > }
> > if (m->flags & MOPT_CLEAR_ERR)
> > clear_opt(sb, ERRORS_MASK);
>
> Why is this change needed? This is in the handling of options that
> have MOPT_EXPLICIT, and it doesn't seem relevant to this commit?
You are right, this change is an irrelevant change. I'll remove it in
next version. Thanks!
>
> - Ted
