On Mon 21-10-19 20:17:31, Matthew Bobrowski wrote: > Separate the iomap field population chunk of code that is currently > within ext4_iomap_begin() into a new helper called > ext4_set_iomap(). The intent of this function is self explanatory, > however the rationale behind doing so is to also reduce the overall > clutter that we currently have within the ext4_iomap_begin() callback. > > Signed-off-by: Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx> > --- > fs/ext4/inode.c | 59 +++++++++++++++++++++++++++---------------------- > 1 file changed, 33 insertions(+), 26 deletions(-) The patch looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR