On Mon 30-09-19 11:05:53, Theodore Y. Ts'o wrote: > On Mon, Sep 30, 2019 at 08:26:27PM +0800, kbuild test robot wrote: > > Hi Jan, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on ext4/dev] > > [cannot apply to v5.3 next-20190930] > > [if your patch is applied to the wrong git tree, please drop us a note to help > > improve the system. BTW, we also suggest to use '--base' option to specify the > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > > > url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Fix-transaction-overflow-due-to-revoke-descriptors/20190930-184615 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > > config: x86_64-randconfig-a004-201939 (attached as .config) > > compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 > > reproduce: > > # save the attached .config to linux build tree > > make ARCH=x86_64 > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > > > All errors (new ones prefixed by >>): > > > > fs/jbd2/transaction.c: In function 'jbd2_journal_start_reserved': > > >> fs/jbd2/transaction.c:596:20: error: 'handle_t {aka struct jbd2_journal_handle}' has no member named 'h_buffer_credits' > > line_no, handle->h_buffer_credits); > > ^ > > Yep, it looks like this instance of h_buffer_credits was missed in the > patch, probably because Jan wasn't building with tracepoints enabled. > I noticed this when I tried to do a test build. The problem was that my patches were based on a kernel that didn't have this code yet. I've rebased now on current Linus' tree and fixed this up in my local tree (along with couple documentation warnings). But I don't think it's worth resending just for this. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
