On Fri, Sep 20, 2019 at 08:50:36AM -0400, Qian Cai wrote: > On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote: > > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > > in __lock_release"), @nested is no longer used in lock_release(), so > > > remove it from all lock_release() calls and friends. > > > > > > Signed-off-by: Qian Cai <cai@xxxxxx> > > > --- > > > > Although this looks fine to me at a first glance, it might be slightly > > easier to manage if you hit {spin,rwlock,seqcount,mutex,rwsem}_release() > > first with coccinelle scripts, and then hack lock_release() as a final > > patch. That way it's easy to regenerate things if needed. > > I am not sure if it worth the extra efforts where I have to retest it on all > architectures, and the patch is really simple, but I can certainly do that if > you insist. I'm not insisting, just thought it might be easier to get it merged that way. If you prefer to go with the big diff, Acked-by: Will Deacon <will@xxxxxxxxxx> Will