Re: [PATCH] po: remove unnecessary/buggy positional parameter specifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 13-07-19 om 18:57 schreef Theodore Ts'o:
> The strings in e2fsck/problem.c use a special %-expansion scheme,
> where %b gets expanded to a block number, %i gets expanded to an inode
> number, etc., where these values are in a problem context data
> structure.  As such, there is no need to use a printf style positional
> indicator (e.g., %2$s).  Indeed, the use of things like %1$i or %2$b
> will cause the %-expansion code to just print %1$i or %2$b, instead of
> the inode or block number, respectively.
> 
> Addresses-Debian-Bug: #892173

The proposed corrections have been applied by the translators to the Czech,
Dutch and German PO files, and manually by myself to the Vietnamese PO file .

Attached is a small patch to remove a superfluous no-c-format tag.

Benno
>From eaf3e708719d60942cfadfb64c8f73e8bb54a2a5 Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg@xxxxxxxxxx>
Date: Thu, 1 Aug 2019 12:03:31 +0200
Subject: [PATCH] e2fsck: remove an ineffective (because trailing)
 xgettext:no-c-format tag

Signed-off-by: Benno Schulenberg <bensberg@xxxxxxxxxx>
---
 e2fsck/problem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index c45c6b78..5971a503 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -705,7 +705,7 @@ static struct e2fsck_problem problem_table[] = {
 	/* Relocating group number's information to X */
 	{ PR_1_RELOC_TO,
 	  /* xgettext:no-c-format */
-	  N_("Relocating @g %g's %s to %c...\n"), /* xgettext:no-c-format */
+	  N_("Relocating @g %g's %s to %c...\n"),
 	  PROMPT_NONE, PR_PREEN_OK, 0, 0, 0 },
 
 	/* Warning: could not read block number of relocation process */
-- 
2.22.0


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux