On 6/24/19 5:58 AM, Jan Kara wrote: > On Fri 21-06-19 18:27:13, Eric Sandeen wrote: >> The code in quota_getstate and quota_getstatev is strange; it >> says the returned fs_quota_stat[v] structure has room for only >> one type of time limits, so fills it in with the first enabled >> quota, even though every quotactl command must have a type sent >> in by the user. >> >> Instead of just picking the first enabled quota, fill in the >> reply with the timers for the quota type that was actually >> requested. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >> --- >> >> I guess this is a change in behavior, but it goes from a rather >> unexpected and unpredictable behavior to something more expected, >> so I hope it's ok. >> >> I'm working on breaking out xfs quota timers by type as well >> (they are separate on disk, but not in memory) so I'll work >> up an xfstest to go with this... > > Yeah, makes sense. I've added the patch to my tree. > > Honza > Thanks Jan - if you'd like to fix my "quote" for "quota" in the subject line, please feel free. ;) -Eric
