Hi,
> You are right for this and we also need take care of this in EXT4_IOC_FSSETXATTR/
> this is a bit strange behavior as chattr read existed flags
> but could not set them again, there are several possible ways that I could think
> of to fix the issue?
>
> 1) change chattr to filter Project inherit bit before call FS_IOC_SETFLAGS
>
> 2) we automatically fixed the flag before mask check, something like:
> if reg:
> flags &= ~PROJECT_INHERT;
> if (ext4_mask_flags(inode->i_mode, flags) != flags)
> return -EOPNOTSUPP;
> But this might be not good..
>
> I would prefer solution 1)
> What do you think?
Existing versions of chattr can't be changed, and people don't necessarily
upgrade the kernel and e2fsprogs at the same time. So (1) wouldn't really work.
A better solution might be to make FS_IOC_GETFLAGS and FS_IOC_FSGETXATTR never
return the project inherit flag on regular files.
- Eric
>>>>>>
How about fix it in __ext4_iget():
ei->i_flags = le32_to_cpu(raw_inode->i_flags);
if (S_ISREG(inode->i_mode))
ei->i_flags &= ~EXT4_PROJINHERIT_FL;
This way will give a big chance flag will be automatically fixed
next time whenever inode is dirtied.
Thanks,
Shilong
