On Fri, May 24, 2019 at 06:41:29PM -0400, Gabriel Krisman Bertazi wrote:
> Found by visual inspection, this wasn't caught by my xfstest, since it's
> effect is ignoring positive dentries in the cache the fallback just goes
> to the disk. it was introduced in the last iteration of the
> case-insensitive patch.
>
> d_compare should return 0 when the entries match, so make sure we are
> correctly comparing the entire string if the encoding feature is set and
> we are on a case-INsensitive directory.
>
> Fixes: b886ee3e778e ("ext4: Support case-insensitive file name lookups")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx>
Applied, thanks.
I'll note that half the implementations of *_d_compare seem to use
!!memcmp(), and half use memcmp().
The callers of d_compare only seems to care if it's 0 or != 0, so I
guess it doesn't matter...
- Ted
