On Fri, May 17, 2019 at 11:25:06AM +0100, Lee Jones wrote: > On Fri, 17 May 2019, Philippe Mazenauer wrote: > > > Variables 'n' and 'err' are both used for less-than-zero error checking, > > however both are declared as unsigned. Ensure ext4_map_blocks() and > > add_system_zone() are able to have their return values propagated > > correctly by redefining them both as signed integers. This is already fixed in the ext4.git tree; it will be pushed to Linus shortly. (Thanks to Colin Ian King from Canonical for sending the patch.) > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> Lee, techncially this should have been Reviewed-by. Acked-by is used by the maintainer when a patch is going in via some other tree other than the Maintainer's (it means the Maintainer has acked the patch). If you are reviewing a patch, the tag you should be adding is Reviewed-by. Cheers, - Ted
