Re: [PATCH] debugfs: fix encoding handling in dx_hash command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 23, 2019 at 12:07:12AM -0400, Gabriel Krisman Bertazi wrote:
> Eric Biggers <ebiggers@xxxxxxxxxx> writes:
> 
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> >
> > Fix the following bugs:
> >
> > 1. 'encoding' and 'hash_flags' are not initialized, causing a segfault.
> >
> > 2. 'hash_flags' incorrectly uses a __bitwise type.
> >
> > 3. The optstring doesn't contain "c" or "e", so the -c and -e options
> >    aren't recognized.
> >
> > 4. The code that handles the -e option always returns.
> >
> 
> Ugly. Thanks for finding it.
> 
> Reviewed-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx>

Thanks, applied.

						- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux