Re: [PATCH] e2fsck: Do not to be quiet if verbose option used.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 26, 2019 at 04:09:13PM +0300, Artem Blagodarenko wrote:
> From: Alexey Lyashkov <c17817@xxxxxxxx>
> 
> e2fsck don't print a message if 'p' option used and error can be fixed without
> user assistance,  but 'v' option asks to be more verbose, so user expect to
> see any output. But not.
> Fix this, by avoid message suppress with verbose option used.
> 
> Change-Id: I358e9b04e44dd33fdb124c5663b2df0bf54ce370
> Signed-off-by: Alexey Lyashkov <c17817@xxxxxxxx>
> Cray-bug-id: LUS-6890

I need to understand the use case of what you are trying to do here.
The preen and verbose options were never intended to be mixed and this
patch changes what the verbose flag does at a fairly fundamental
level.  I'm not sure the results will be correct and they will almost
certainly be surprising.

So (a) what is the user trying to do, and (b) what does the user want
to be trying to do?  Preen was intended to be used as part of the boot
process, when multiple e2fsck's would be running in parallel, and so
you don't *want* much in the way of verbosity.

    	  	      	     	    - Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux