Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
From: David Howells <dhowells@xxxxxxxxxx>
Date: Thu, 18 Apr 2019 17:12:13 +0100
Cc: dhowells@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, Jan Harkes <jaharkes@xxxxxxxxxx>, coda@xxxxxxxxxx, codalist@xxxxxxxxxxxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20190418161024.GG7751@bombadil.infradead.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <20190418161024.GG7751@bombadil.infradead.org> <155559635133.21702.4737487773869377967.stgit@warthog.procyon.org.uk> <155559636704.21702.4538723150377303298.stgit@warthog.procyon.org.uk>

Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> Don't you also need to delete the remove_inode_hash() and
> __insert_inode_hash() calls?

Yep.  Good point.

David

References:
- Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
  - From: Matthew Wilcox
- [RFC PATCH 0/6] vfs: Make icache searchable under RCU
  - From: David Howells
- [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
  - From: David Howells

Prev by Date: Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
Next by Date: Re: [PATCH v5 1/6] libnvdimm: nd_region flush callback support
Previous by thread: Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
Next by thread: [RFC PATCH 2/6] vfs: Change inode_hash_lock to a seqlock
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]