Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx
Subject: Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
From: Jan Harkes <jaharkes@xxxxxxxxxx>
Date: Thu, 18 Apr 2019 10:48:50 -0400
Cc: coda@xxxxxxxxxx, dhowells@xxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <155559636704.21702.4538723150377303298.stgit@warthog.procyon.org.uk>
References: <155559635133.21702.4737487773869377967.stgit@warthog.procyon.org.uk> <155559636704.21702.4538723150377303298.stgit@warthog.procyon.org.uk>

That looks good to me.

Acked-by: Jan Harkes <jaharkes@xxxxxxxxxx>


On April 18, 2019 10:06:07 AM EDT, David Howells <dhowells@xxxxxxxxxx> wrote:
>- but, as the comment notes, this really needs some locking.
>
>Fix this by moving the core part of the code to fs/inode.c and

References:
- [RFC PATCH 0/6] vfs: Make icache searchable under RCU
  - From: David Howells
- [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
  - From: David Howells

Prev by Date: Re: [RFC PATCH 5/6] ext4: Search for an inode to update under the RCU lock if we can
Next by Date: [PATCH v2] ext4: fix use-after-free race with debug_want_extra_isize
Previous by thread: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
Next by thread: Re: [RFC PATCH 1/6] vfs, coda: Fix the lack of locking in FID replacement inode rehashing
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]