Re: [PATCH] ext4: use BUG() instead of BUG_ON(1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Arnd Bergmann <arnd@xxxxxxxx>
Subject: Re: [PATCH] ext4: use BUG() instead of BUG_ON(1)
From: "Theodore Ts'o" <tytso@xxxxxxx>
Date: Sun, 7 Apr 2019 12:29:39 -0400
Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx>, clang-built-linux@xxxxxxxxxxxxxxxx, Nick Desaulniers <ndesaulniers@xxxxxxxxxx>, Nathan Chancellor <natechancellor@xxxxxxxxx>, Eric Whitney <enwlinux@xxxxxxxxx>, Sean Fu <fxinrong@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20190325130040.1437445-1-arnd@arndb.de>
Mail-followup-to: Theodore Ts'o <tytso@xxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, clang-built-linux@xxxxxxxxxxxxxxxx, Nick Desaulniers <ndesaulniers@xxxxxxxxxx>, Nathan Chancellor <natechancellor@xxxxxxxxx>, Eric Whitney <enwlinux@xxxxxxxxx>, Sean Fu <fxinrong@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
References: <20190325130040.1437445-1-arnd@arndb.de>
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Mar 25, 2019 at 02:00:25PM +0100, Arnd Bergmann wrote:
> BUG_ON(1) leads to bogus warnings from clang when
> CONFIG_PROFILE_ANNOTATED_BRANCHES is set:
> 
>	....
> 
> Change it to BUG() so clang can see that this code path can never
> continue.

Thanks, applied.

					- Ted

References:
- [PATCH] ext4: use BUG() instead of BUG_ON(1)
  - From: Arnd Bergmann

Prev by Date: Re: [PATCH v2] ext4: fix prefetchw of NULL page
Next by Date: Re: [PATCH] bootfs: simple bootloader filesystem
Previous by thread: Re: [PATCH] ext4: use BUG() instead of BUG_ON(1)
Next by thread: [PATCH v6 05/07] ext4: use common file type conversion
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]