Re: [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 19-03-19 13:38:18, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(),
> which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's
> crypto engine") but the comment was accidentally left in place.  Since
> ext4_encrypted_inode() has now been removed, just remove the comment.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ext4/ext4.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 82ffdacdc7fac..2a2e6ed9aab4f 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1592,9 +1592,6 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
>  #define EXT4_SB(sb)	(sb)
>  #endif
>  
> -/*
> - * Returns true if the inode is inode is encrypted
> - */
>  #define NEXT_ORPHAN(inode) EXT4_I(inode)->i_dtime
>  
>  /*
> -- 
> 2.21.0.225.g810b269d1ac-goog
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux