On Thu, Mar 21, 2019 at 06:08:19PM -0400, Theodore Ts'o wrote:
> On Thu, Mar 21, 2019 at 06:04:40PM -0400, Theodore Ts'o wrote:
> > OK, I've reworked the function to read:
> >
> > ls_scan_targets() {
> > lsblk -o NAME,MOUNTPOINT,FSTYPE -P -n -p \
> > $(lvs -o lv_path --noheadings -S "lv_active=active,lv_role=public,lv_role!=snapshot,vg_free>${snap_size_mb}") | \
> > grep FSTYPE=\"ext\[234\]\" | while read vars ; do
> > eval "${vars}"
> >
> > if [ "${scrub_all}" -eq 1 ] || [ -n "${MOUNTPOINT}" ]; then
> > echo ${MOUNTPOINT:-${NAME}}
> > fi
> > done | sort | uniq
> > }
> >
> > I think that's the final answer....
>
> And I just saw your e-mail about dropping the sort and uniq calls.
> OK, I'll take care of that too.
>
> - Ted
Great, I like it and it runs very fast on my system.
cold cache
real 0m0.268s
user 0m0.011s
sys 0m0.036s
second run
real 0m0.053s
user 0m0.013s
sys 0m0.031s
Thanks for working on this.
-Lukas
