Re: [PATCH v2 2/2] ext4: Report real fs size after failed resize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 15, 2019 at 12:23:58AM -0400, Theodore Ts'o wrote:
> On Tue, Mar 05, 2019 at 11:54:00AM +0100, Lukas Czerner wrote:
> > Currently when the file system resize using ext4_resize_fs() fails it
> > will report into log that "resized filesystem to <requested block
> > count>". However this may not be true in the case of failure. Use the
> > current block count as returned by ext4_blocks_count() to report the
> > block count.
> > Additionally report to log that "error occurred during file system
> > resize"
> > 
> > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> 
> Thanks, applied with one minor change.  In call to ext4_warning(), I
> changed it to include error code so the warning message will be more
> useful:
> 
> > +	if (err)
> > +		ext4_warning(sb, "error occurred during file system resize");
> 
> is now
> 
> +       if (err)
> +               ext4_warning(sb, "error (%d) occurred during "
> +                            "file system resize", err);

Yeah, that's better.

Thanks!
-Lukas

> 
>   				 		 - Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux