On Wed 16-01-19 18:56:17, Amir Goldstein wrote: > On Wed, Jan 16, 2019 at 6:51 PM Jan Kara <jack@xxxxxxx> wrote: > > > > On Wed 16-01-19 16:34:36, Phillip Potter wrote: > > > Dear Jan, > > > > > > I am happy to rework the patches, all fair comment. Slight problem > > > being my computer is in a box right now as I've just moved house. I > > > will get this done in the next few days if that's ok? > > > > Sure, no problem. Patches won't make it in this release cycle so we have > > like three weeks to get them ready for the next merge window. > > > > Also, and Jan will correct me if I am wrong. > I think that reworking only the common and ext2 patches would > be sufficient for this cycle. Yes, that's also true. > You can prepare the rest of the patches for next cycle after > the common patch has landed. Correct, since the plan is for these to land through other maintainers' trees. But still it would be nice if we had them earlier just to see of other maintainers don't seriously oppose the idea. To that end it is probably good to reference the discussion with Linus in the cover letter and the email with common infrastructure, explaining why converting to common defines instead of keeping filesystem specific ones was done. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
