On Sat, Nov 17, 2018 at 05:01:52PM +0800, Chengguang Xu wrote: > If new mode is the same as old mode we don't have to reset > inode mode in the rest of the code, so compare old and new > mode before setting update_mode flag. > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx> Thanks, applied. I know Jan declined the equivalent patch for ext2; but it doesn't add _that_ much extra complexity, and ext4_mark_inode_dirty() is rather more heavyweight than ext2_mark_inode_dirty(). - Ted