On Tue, Nov 27, 2018 at 10:14:53AM +0100, Jan Kara wrote: > On Mon 26-11-18 11:21:06, Pan Bian wrote: > > The function frees qf_inode via iput but then pass qf_inode to > > lockdep_set_quota_inode on the failure path. This may result in a > > use-after-free bug. The patch frees df_inode only when it is never used. > > > > Signed-off-by: Pan Bian <bianpan2016@xxxxxxx> > > Fixes: daf647d2dd5("ext4: add lockdep annotations for i_data_sem") > > Thanks for the fix! The patch looks good. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Thanks, applied. - Ted