On Wed, Nov 28, 2018 at 12:09:26PM -0700, Andreas Dilger wrote: > On Nov 28, 2018, at 9:08 AM, Artem Blagodarenko <artem.blagodarenko@xxxxxxxxx> wrote: > > > > Commits "Reserve feature bit and SB field bit for filename encoding" > > and "Add timestamp extension bits to superblock" change > > ext2_super_block structure, but don't change tst_super_size test, > > so "make check" fails with message: > > > > error: s_reserved size 380 should be 392 > > How did these patches even land without "make check" being run once? > Does this test failure not cause "make check" to fail? My bad; I failed to run the make check before pushing it out. I fixed this before seeing Artem's patch, and the fix was what he pushed out. - Ted