Re: [PATCH] e2freefrag: fix free blocks count during live scan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 08, 2018 at 10:44:31AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> In e2freefrag live scan mode, we take the free block count from the
> ondisk superblock.  This leads to screwy histogram percentages:
> 
> Extent Size Range :  Free extents   Free Blocks  Percent
>     4M...    8M-  :             5          8234    1.05%
>    64M...  128M-  :             2         52279    6.64%
>   512M... 1024M-  :             1        202752   25.74%
> 
> ...because there could be superblock updates in the journal that haven't
> yet been checkpointed.  The online scan is perfectly capable of tallying
> the free blocks on its own, so teach it do that and make a more accurate
> report.
> 
> Reported-by: Elana Hashman <Elana.Hashman@xxxxxxxxxxxx>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Thanks, applied.

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux