Re: [RFC][PATCH v4 04/09] ext2: use common file type conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 22, 2018 at 1:40 PM Jan Kara <jack@xxxxxxx> wrote:
>
> On Wed 21-11-18 19:06:53, Phillip Potter wrote:
> > Deduplicate the ext2 file type conversion implementation - file systems
> > that use the same file types as defined by POSIX do not need to define
> > their own versions and can use the common helper functions decared in
> > fs_types.h and implemented in fs_types.c
> >
> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>

Jan,

As you know, Al probably has bigger fish to fry at the moment.
Will you take this patch along with patch #1 through your tree?
Other fs maintainers could apply patches on next cycle (or coordinate
they pull request with you).

If you would agree to that, I suggest to copy the following section
from the cover letter into the ext2 patch:

The current implementation has a lurking out-of-bounds access
bug to the ext2_type_by_mode array.
The array is defined with size S_IFMT >> S_SHIFT, so 15.
This means that it is possible with a malformed inode to
get an index of 15, as the array is always accessed with:
ext2_type_by_mode[(mode & S_IFMT)>>S_SHIFT];

Thanks,
Amir.



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux