On Wed, Nov 21, 2018 at 05:08:11PM +0100, Christoph Hellwig wrote:
> On Wed, Nov 21, 2018 at 11:06:11PM +0800, Ming Lei wrote:
> > bvec_iter_* is used for single-page bvec in current linus tree, and there are
> > lots of users now:
> >
> > [linux]$ git grep -n "bvec_iter_*" ./ | wc
> > 191 995 13242
> >
> > If we have to switch it first, it can be a big change, just wondering if Jens
> > is happy with that?
>
> Your above grep statement seems to catch every use of struct bvec_iter,
> due to the *.
>
> Most uses of bvec_iter_ are either in the block headers, or are
> ceph wrappers that match the above and can easily be redefined.
OK, looks you are right, seems not so widely used:
$ git grep -n -w -E "bvec_iter_len|bvec_iter_bvec|bvec_iter_advance|bvec_iter_page|bvec_iter_offset" ./ | wc
36 194 2907
I will switch to that given the effected driver are only dm, nvdimm and ceph.
Thanks,
Ming
