"Theodore Y. Ts'o" <tytso@xxxxxxx> writes: > On Tue, Nov 20, 2018 at 07:11:27PM -0500, Gabriel Krisman Bertazi wrote: >> New superblock fields must be byte swapped before being accessed in Big >> Endian machines. >> >> Not tested on an actual BE machine. >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> >> --- >> >> I just noticed this today. I don't see the patch that includes this >> field already pushed to kernel.org, so if you want to squash this one to >> that patch before pushing to make the result more bisectable in BE >> machines, I am ok with that. > > Oops, sorry, I just pushed it out before I saw your note. I'll add it > as a follow-on commit right away. Fortunately we don't do too much > debugging on BE machines, so it's probably not worth breaking the git > rules and rewinding, even though it's highly unlikely anyone has done > a git pull in the last 10 minutes or so. > > While we're at it, I should have noticed this earler before I acceptd > patch 2 in your series. Could you also send a follow up patch which > adds a quick description of the fname_encoding feature to the ext4.5 > man page? Hi, Thanks for pushing it and yes, I can send the follow up patch. > > Also, did your v2 patch series to e2fsprogs reflect any of the > comments I made late last night on the rest of the v1 patch series? No, it only reflects the comments you made on the night before, up to patch 3/10, as I hadn't seen your new responses before submitting v2. So, please disregard v2, and I will follow up with a new iteration applying your new suggestions. Thanks. -- Gabriel Krisman Bertazi
