On Fri, 31 Aug 2018 11:33:48 +0530 Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote: > > > Return type of block_page_mkwrite_return() is also changed > > > to use new vm_fault_t type. > > > --- a/fs/nilfs2/file.c > > > +++ b/fs/nilfs2/file.c > > > @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync) > > > return err; > > > } > > > > > > -static int nilfs_page_mkwrite(struct vm_fault *vmf) > > > +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf) > > > > nilfs_page_mkwrite() already has return type vm_fault_t in Linus's > > kernel, due to the now-merged > > fs-nilfs2-adding-new-return-type-vm_fault_t.patch. Looks like a simple > > fix. > > > > I'm beginning to feel vm_fault_t exhaustion. Please remind me what > > benefit we're going to get out of all this churn? > > The problem and benefit of these changes was discussed under this mail > thread when the first vm_fault_t patch was posted. > > https://marc.info/?l=linux-mm&m=152054772413234&w=4 That tells us about the merging plans. But not much about what actual benefit anyone gets from this. This? : There's some interesting patterns and commonalities between drivers : (not to mention a few outright bugs) that we've noticed, and this'll be : a good time to clean them up. That is terribly vague.
