On Tue, Aug 21, 2018 at 10:25:32AM -0700, Eric Biggers wrote: > On Tue, Aug 21, 2018 at 09:51:59AM +0200, Lukas Czerner wrote: > > MKINSTALLDIRS variable is not defined in scrub/Makefile for > > creating the directories. Use MKDIR_P instead. > > > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > --- > > scrub/Makefile.in | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/scrub/Makefile.in b/scrub/Makefile.in > > index f58331de..fc8cbcfd 100644 > > --- a/scrub/Makefile.in > > +++ b/scrub/Makefile.in > > @@ -85,24 +85,24 @@ e2scrub_all_cron: e2scrub_all_cron.in > > $(Q) $(SUBSTITUTE_UPTIME) $< $@ > > > > installdirs-udev: > > - $(E) " MKINSTALLDIRS $(UDEV_RULES_DIR)" > > - $(Q) $(MKINSTALLDIRS) $(DESTDIR)$(UDEV_RULES_DIR) > > + $(E) " $(MKDIR_P) $(DESTDIR)$(UDEV_RULES_DIR)" > > + $(Q) $(MKDIR_P) $(DESTDIR)$(UDEV_RULES_DIR) > > Nit: the other Makefile.in's in e2fsprogs have "MKDIR_P" in the $(E) echo line, > not "$(MKDIR_P)". > Also this patch adds $(DESTDIR) to the echo line here, but it's not in any of the other ones. - Eric
