On Tue, May 29, 2018 at 08:45:14PM +0900, Wang Shilong wrote: > From: Wang Shilong <wshilong@xxxxxxx> > > Cleanup to handle ext4 error codes together with > bitmaps corrupted bits setting. > > Signed-off-by: Wang Shilong <wshilong@xxxxxxx> > Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx> > --- > fs/ext4/balloc.c | 28 +++++++++++++++------------- > fs/ext4/ext4.h | 35 ++++++++++++++++++++++++----------- > fs/ext4/ialloc.c | 37 +++++++++++++++++++------------------ > fs/ext4/mballoc.c | 20 ++++++++------------ > fs/ext4/super.c | 11 +++++++---- > 5 files changed, 73 insertions(+), 58 deletions(-) This change makes the code longer and it's **really** not clear why it is a "cleanup". This is an example of explaining *why* is often far more important than the *what*. - Ted
