On Tue 24-04-18 14:35:36, Theodore Ts'o wrote: > On Tue, Apr 24, 2018 at 10:27:12AM -0600, Michal Hocko wrote: > > fs/ext4/xattr.c > > > > What to do about this? Well, there are two things. Firstly, it would be > > really great to double check whether the GFP_NOFS is really needed. I > > cannot judge that because I am not familiar with the code. > > *Most* of the time it's not needed, but there are times when it is. > We could be more smart about sending down GFP_NOFS only when it is > needed. If we are sending too many GFP_NOFS's allocations such that > it's causing heartburn, we could fix this. (xattr commands are rare > enough that I dind't think it was worth it to modulate the GFP flags > for this particular case, but we could make it be smarter if it would > help.) There still seem to be ext4_kvmalloc(NOFS) callers in the ext4 code. Do you have any plans to get rid of those? -- Michal Hocko SUSE Labs
