Re: [PATCH 17/20] ext4: Include encoding information in the superblock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



As the kbuild bot has already reported, you've added an unconditional
dependency on the NLS subsystem, which is not always compiled in.
What we need to do is to add #ifdef's on CONFIG_NLS, and only support
file systems with encoding if the kernel is compiled with CONFIG_NLS.

One thought --- do we really need to use CONFIG_NLS if the encoding is
ASCII?  If some use case (and Android may be one) only is interested
in supporting case-folding for ASCII, and they don't want to have the
overhead of compiling in the NLS subsystem, for ASCII couldn't use
just use strcasecmp() for its comparison function?

The normalization for ASCII is the identify function, so it's kind of
pointless to support ASCII if we ony have case-folding support and not
normalization for now, right?

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux