"Theodore Y. Ts'o" <tytso@xxxxxxx> writes: > On Tue, Jul 03, 2018 at 01:06:41PM -0400, Gabriel Krisman Bertazi wrote: >> Generated with the following coccinele script: >> >> <smpl> >> >> @@ >> expression A, B, C, D; >> @@ >> ( >> - A->uni2char(B, C, D) >> + nls_uni2char(A, B, C, D) >> | >> - A->char2uni(B, C, D) >> + nls_char2uni(A, B, C, D) >> ) >> >> </smpl> >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx> > > It would be really helpful if in addition to describe *what* the > commit does, to also describe *why*. What is the purpose of adding an > inline function to wrap the indirection? This is especially important > since there is no real maintainer and no real development for NLS (and > hence not a lot of people who have a lot of expertise with the code). > So having some explanation in the NLS commits in this series would be > very useful. > Hi, Sorry about that. I will fix the commit messages in the next iteration to add the explanation below. For char2uni/uni2char it was simply meant to simplify the output of patch 3, which was generated by coccinelle to make it touch less things at once. For other fields, in particular charset2lower/charset2upper, it will allow a future patch to drop the tables of ascii and utf8n, for instance, and do the conversion algorithmically, which will simplify the nls code. -- Gabriel Krisman Bertazi
