On Jul 2, 2018, at 3:56 PM, Theodore Y. Ts'o <tytso@xxxxxxx> wrote: > > Artem, it looks like you're just blasting changes from the Lustre fork > of e2fsprogs without doing any sanity checking or clean up. Maybe > there is a somewhat lower standard of quality for the Lustre fork of > e2fsprogs, but I'd really appreciate it if you could add value by > cleaning up the patches before you submit them for upstream inclusion. > > Sending lower-quality patches degrades both your open source > reputation as well as the reputation of the Lustre project. The original versions of these patches were created on much older versions of e2fsprogs (1.41 or earlier), so it is entirely possible that some of them are now outdated, which is why I haven't been sending them upstream myself. They definitely need to be reviewed more closely to see if they are still relevant to newer e2fsprogs. Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
