On Jul 2, 2018, at 3:26 PM, Theodore Y. Ts'o <tytso@xxxxxxx> wrote: > > On Wed, Jun 27, 2018 at 12:57:44PM +0300, c17828 wrote: >> diff --git a/tests/test_one.in b/tests/test_one.in >> index c1f18dc8..27e0ca64 100644 >> --- a/tests/test_one.in >> +++ b/tests/test_one.in >> @@ -81,6 +81,7 @@ if [ $elapsed -gt 60 -a ! -f $test_dir/is_slow_test ]; then >> tee $test_name.slow >> echo "$test_name: consider adding $test_dir/is_slow_test" >> fi >> +[ -f $test_name.failed ] && grep . $test_name.failed >> > > This change has nothing to do with the rest of the patch. I'm also > not sure it good idea, because sometimes the output of the foo.failed > file can be quite large. Also, if running multiple tests in parallel > which fail, the output can look quite awful. Finally, why use "grep ." > instead of "cat"? The reason for "grep ." instead of "cat" is so that the filename is prepended to the output. This is a useful trick when looking at the content of several files at once. > I can see possibly adding this to test_script, but it doesn't belong > in test_one, and it should be in its own separate commit. > > I'm going to drop this change to test_one.in, but I'll take the rest > of the patch. Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
