On 06/20/2018 12:31 PM, Andreas Dilger wrote:
On Jun 6, 2018, at 2:26 AM, Chengguang Xu <cgxu519@xxxxxxx> wrote: Currently duplicate data to orig_data in ext4_remount() but there is lack of check for duplication result. This patch adds proper check for it. Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx>Thank you for the patch. I think it looks correct, but I was initially confused by the commit message. I think something like the following would be more clear: There is no check for allocation failure when duplicating "orig_data" in ext4_remount(). Check for failure and return an error in this case. While I don't think it is (currently) possible for a one-page allocation to fail (always true because of copy_mount_options() used in ksys_mount()), I prefer to always check for allocation failures in case this ever changes in the future, or if there is allocation fault injection or other fuzzing turned on. In any case, you can add: Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>
Thanks for your review, I'll modify changelog in v2. Thanks, Chengguang.
