Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 16 May 2018 11:58:02 +0200
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-rtc@xxxxxxxxxxxxxxx, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Jiri Slaby <jslaby@xxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Alexey Dobriyan <adobriyan@xxxxxxxxx>, megaraidlinux.pdl@xxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx
In-reply-to: <20180516094346.20506-42-hch@lst.de>
References: <20180516094346.20506-1-hch@lst.de> <20180516094346.20506-42-hch@lst.de>
User-agent: Mutt/1.9.5 (2018-04-13)

On Wed, May 16, 2018 at 11:43:45AM +0200, Christoph Hellwig wrote:
> Just set up the show callback in the tty_operations, and use
> proc_create_single_data to create the file without additional
> boilerplace code.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

References:
- simplify procfs code for seq_file instances V3
  - From: Christoph Hellwig
- [PATCH 41/42] tty: replace ->proc_fops with ->proc_show
  - From: Christoph Hellwig

Prev by Date: [PATCH 23/42] afs: simplify procfs code
Next by Date: [PATCH 24/42] ext4: simplify procfs code
Previous by thread: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show
Next by thread: [PATCH 40/42] ide: replace ->proc_fops with ->proc_show
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]